Update more-views-and-viewsets.rst #68
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed several grammatical typos and reword the section on combining `PollList` and `PollDetail` to a viewset for clarity.
yvsssantosh
reviewed
Aug 7, 2021
Comment on lines
-16
to
+17
| - :code:`/polls/<pk>/choices/` to GET the choices for a specific poll, and to create choices for a specific poll. (Idenitfied by the :code:`<pk>`) | ||
| - :code:`/polls/<pk>/choices/<choice_pk>/vote/` - To vote for the choice identified by :code:`<choice_pk>` under poll with :code:`<pk>`. | ||
| - :code:`/polls/<pk>/choices/` - to GET the choices for a specific poll, and to create choices for a specific poll. (Identified by the :code:`<pk>`) | ||
| - :code:`/polls/<pk>/choices/<choice_pk>/vote/` - to vote for the choice identified by :code:`<choice_pk>` under poll with :code:`<pk>`. |
There was a problem hiding this comment.
Adding just the - doesn't make sense. Indent the code for better readability.
There was a problem hiding this comment.
Something like this:
- :code:`/polls/<pk>/choices/` - to GET the choices for a specific poll, and to create choices for a specific poll. (Identified by the :code:`<pk>`)
- :code:`/polls/<pk>/choices/<choice_pk>/vote/` - to vote for the choice identified by :code:`<choice_pk>` under poll with :code:`<pk>`.
yvsssantosh
reviewed
Aug 7, 2021
Comment on lines
+158
to
+167
| ```py | ||
| class PollList(generics.ListCreateAPIView): | ||
| queryset = Poll.objects.all() | ||
| serializer_class = PollSerializer | ||
|
|
||
|
|
||
| class PollDetail(generics.RetrieveDestroyAPIView): | ||
| queryset = Poll.objects.all() | ||
| serializer_class = PollSerializer | ||
| ``` |
There was a problem hiding this comment.
This is a generic view, not viewset. Please revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed several grammatical typos and reword the section on combining
PollListandPollDetailto a viewset for clarity.